Low, CVSS 2.3GoPublished
Bad documentation of error handling in ParseWithClaims can lead to potentially dangerous situations
CVE-2024-51744 · GHSA-29wx-vh33-7x7r
- Affected
- Go github.com/golang-jwt/jwt/v4 < 4.5.1
- Fixed in
- 4.5.1· Vendor fix available
- Issue
- Unclear documentation of the error behavior in ParseWithClaims can lead to situation where users are potentially not checking errors in the way they should be. Especially, if a token is both expired and invalid, the errors returned by ParseWithClaims return both error codes. If users only check for the jwt.ErrTokenExpired using error.Is, they will ignore the embedded jwt.ErrTokenSignatureInvalid and thus potentially accept invalid tokens. Fix We have back-ported the error handling logic from the v5 branch to the v4 branch. In this logic, the ParseWithClaims function will immediately return in "dangerous" situations (e.g., an invalid signature), limiting the combined errors only to situations where the signature is valid, but further validation failed (e.g., if the signature is valid, but is expired AND has the wrong audience). This fix is part of the 4.5.1 release. Workaround We are aware that this changes the behaviour of an established function and is not 100 % backwards…
Recommended action: Upgrade to 4.5.1 or later, then redeploy and verify.A vendor fix does not resolve your finding until you verify it in your own systems.