Critical, CVSS 9.1crates.ioPublished
BIP-322 address ownership verification bypass for P2WPKH and P2SH-P2WPKH addresses
GHSA-5chw-87w3-j9cv
- Affected
- crates.io bip322 >= 0.0.6, < 0.0.11
- Fixed in
- 0.0.11· Vendor fix available
- Issue
- Affected versions of `bip322` accepted a BIP-322 proof created with an attacker-controlled private key as a valid signature for an unrelated victim P2WPKH or P2SH-P2WPKH address, allowing complete authentication bypass in applications using `verify_simple`, `verify_simple_encoded`, `verify_full`, or `verify_full_encoded` as proof that a user controls a Bitcoin address. In `verify_full`, the verifier obtained the public key from the caller-controlled witness and passed it to `verify_full_p2wpkh`, where the supposed public-key mismatch check read the key from the same witness and compared it with itself: ```rust let witness_pub_key = &witness.to_vec()[1]; if &pub_key.to_bytes() != witness_pub_key { return Err(Error::PublicKeyMismatch); } ``` Since `pub_key` was originally parsed from that exact witness element, this comparison was tautological. The code verified that the signature was valid for the public key embedded in the witness, but never verified that this public key hashes to…
Recommended action: Upgrade to 0.0.11 or later, then redeploy and verify.A vendor fix does not resolve your finding until you verify it in your own systems.