Unratedcrates.ioPublished
Use-after-free in interned values and cached function results
GHSA-xc3w-55vh-cw3w
- Affected
- crates.io salsa >= 0.23.0, < 0.28.5
- Fixed in
- 0.28.5· Vendor fix available
- Issue
- When an application reads an interned value's fields or uses that value as an input to a tracked function, Salsa must ensure that reusable storage has been validated for the current database revision. This prevents the value's fields and associated cached function results from being freed while in use. Affected versions checked this invariant only with `debug_assert!` when reading fields, and did not check it when using an interned value to access a tracked function's cached result. Bugs in Salsa's dependency tracking, or an application-provided `Eq` implementation that incorrectly treats a changed query result as unchanged, can cause Salsa to reuse cached results containing stale interned values. If the application accesses these values and then interns additional values, Salsa can free the old fields or cached function results while references to them are still in use. This causes use-after-free through safe Rust APIs. Depending on the consuming application, attacker-controlled…
Recommended action: Upgrade to 0.28.5 or later, then redeploy and verify.A vendor fix does not resolve your finding until you verify it in your own systems.